[css-nesting] Remove DeclarationListParser. #338
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
r? @tiaanl |
For nesting, we need to parse declaration and nested rules together. Rather than having DeclarationListParser, organize the parsing code in two: * StyleSheetParser for the top level stylesheet, which has the relevant hacks and so on. * RuleBodyParser which does potentially everything else. For that, introduce a new trait that agglomerates all the nesting needs (so potentially all of at-rule + qualified-rule + declaration parsing). While at it, change the API a little bit so that these take mutable references, so that we can avoid some copying.
tiaanl
approved these changes
May 16, 2023
Collaborator
tiaanl
left a comment
tiaanl
left a comment
There was a problem hiding this comment.
Haven't looked at the implementation of this in fx, but no issues here.
Member
Author
|
@bors-servo r=tiaanl |
Contributor
|
📌 Commit bcbc543 has been approved by |
Contributor
Contributor
|
☀️ Test successful - checks-github |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For nesting, we need to parse declaration and nested rules together. Rather than having DeclarationListParser, organize the parsing code in two:
For that, introduce a new trait that agglomerates all the nesting needs (so potentially all of at-rule + qualified-rule + declaration parsing).
While at it, change the API a little bit so that these take mutable
references, so that we can avoid some copying.